feat(frontend): begin using ui-core#1162
Merged
Merged
Conversation
cbdbcee to
e85813e
Compare
e85813e to
e92d017
Compare
fc93622 to
c60440a
Compare
f2d0ee2 to
bcea1ca
Compare
ui-coreui-core
derrabauke
reviewed
Jun 4, 2026
derrabauke
left a comment
Member
There was a problem hiding this comment.
Two questions otherwise LGTM 🎉
ideally we find a clean way to do this
this is required as we no longer auto install peer deps
bcea1ca to
bb7113b
Compare
derrabauke
approved these changes
Jun 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The goal of this PR is to start using
ui-corein the main timed frontend.Note that this is not a full refactor of the timed frontend, the goal is to introduce
ui-core, show/see if it works, and to incrementally refactor/migrate the rest of the timed frontend in further PRs.For this purpose, this PR will only use the$^{\text{tm}}$ work as a drop-in placement. (which should fix #721 and also (partially) #36)
ReportDurationpickerfromui-core, as it shouldopen points
I'd say these are fine to address in seperate/later PRs
ui-coreis built (while i'm ok with aprebuildscript, having to do the same for other things such astest(withpretest) feels rather suboptimal)tsconfigs, and.npmrcinui-core)