Speak emotion with highest confidence (instead of first one in result)#1
Open
gabehollombe-aws wants to merge 1 commit into
Open
Speak emotion with highest confidence (instead of first one in result)#1gabehollombe-aws wants to merge 1 commit into
gabehollombe-aws wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that when picking which detected emotion to voice, the original code just uses the first one in the Rekognition response list. However, this response from Rekognition is not necessarily ordered, so it often results in a sub-optimal voicing.
This change sorts the emotions and then picks the highest confidence emotion to voice.