Develop #21
Open
Develop #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
habansal
reviewed
May 31, 2021
| </profile> | ||
| <!-- AEM 6.x Profile to include Core Components--> | ||
| <profile> | ||
| <id>classic</id> |
There was a problem hiding this comment.
We don't need to a similar profile for React ?
There was a problem hiding this comment.
@habansal react ...react/all/pom.xml does have the classic profile
Or are you referring to something else?
There was a problem hiding this comment.
@davidjgonzalez I don't remember exactly what i noticed then.
But, looking at it again now, I see that there is indeed similar profile in React as well -
Thanks!
habansal
approved these changes
Jun 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add finished versions of React and Angular projects to a single branch to promote ease of use.
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: