refactor: remove the unused _state slot from the Container#94
Merged
Conversation
Owner
|
I think you’re right. Generally it does not hurt to have extra slots and there’s no automated mechanism to catch them. Hence why this slipped through the cracks. Thanks for taking a careful look. |
adriangb
approved these changes
Feb 1, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
__slots__of theContainerclass has a declared_stateattribute that is never used internally. Is there a reason for declaring it, maybe it should be removed?I found a commit with the first addition of this attribute, but I still don't see a reason for it.
If there is, maybe it should be documented with a comment?