fix: thread FitConfig.seed into fit_frontier → _subsample/_split_buffer #41
Open
Sanjay-Kirti wants to merge 1 commit into
Open
fix: thread FitConfig.seed into fit_frontier → _subsample/_split_buffer #41Sanjay-Kirti wants to merge 1 commit into
Sanjay-Kirti wants to merge 1 commit into
Conversation
FitConfig.seed was persisted to config.json but never forwarded into fit_frontier(). _subsample() and _split_buffer() always used their hardcoded default seed=42, making FitConfig(seed=...) a no-op. Fix: add seed parameter to fit_frontier() and pass config.seed from api.py. Both _subsample() and _split_buffer() already accepted seed as a kwarg; they just never received it. Two tests added: - test_fitconfig_seed_affects_splits: proves _split_buffer produces different splits with different seeds - test_fit_frontier_seed_propagates: proves fit_frontier forwards the seed correctly end-to-end Default behavior unchanged (seed=42 remains the default throughout). Closes adrida#30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FitConfig.seedwas persisted toconfig.jsonbut never forwarded intofit_frontier()._subsample()and_split_buffer()always used their hardcoded defaultseed=42, makingFitConfig(seed=...)a no-op.Reproduction (from #30):