minor: add missing dimension validation to predict_batch()#3
Merged
Conversation
ggSohamgg
commented
Jun 8, 2026
Contributor
adrida
approved these changes
Jun 8, 2026
adrida
left a comment
Owner
There was a problem hiding this comment.
Thanks for this, clean catch. predict() had the guard and predict_batch() didn't, so a wrong-dim array hit route_pipeline and surfaced sklearn's internal error instead. The fix mirrors the existing check exactly: same placement after _to_embeddings, and manifest.embedding_dim is Optional so the is not None guard matches predict()'s legacy-artifact tolerance. Test covers it. Merging, thank you.
Merged
adrida
added a commit
that referenced
this pull request
Jun 8, 2026
Ships everything since 0.1.1 (0.1.2 was bumped in-tree but never tagged): predict_batch() dim guard (#3), FitConfig/EmbeddingConfig fail-fast validation (#4), update() fail-fast on missing all_traces.jsonl (#5), plus the skip_candidates knob and fit() progress logging. Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.