Fix recompose whole app after change languageTag#9
Merged
DevSrSouza merged 2 commits intoMay 10, 2023
Merged
Conversation
|
@DevSrSouza a remark regarding this change, I wonder if this change was the right call,
I think that the language of the app is something that falls under the category of "unlikely to change", and the use of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I used Lyricist in my project and got an issue.
By using the code generated by KSP, after change
languageTagby below way, whole app recomposed and lost current state. That is not what I want.As the description, I expect that it only changes wherever text, but not recompose whole compose tree.
That happen because you use staticCompositionLocalOf which described
So I think we should move to compositionLocalOf because it provides flexible ability. I.E: change language in app settings feature.