Skip to content

Add optional in-place cast Region.astype(dtype, copy=True)#888

Merged
adtzlr merged 4 commits into
mainfrom
enhance-region-astype
Nov 6, 2024
Merged

Add optional in-place cast Region.astype(dtype, copy=True)#888
adtzlr merged 4 commits into
mainfrom
enhance-region-astype

Conversation

@adtzlr

@adtzlr adtzlr commented Nov 6, 2024

Copy link
Copy Markdown
Owner

This PR adds an optional keyword-argument to Region.astype(dtype, copy=True). dtype is now a required argument.

closes #889

@adtzlr adtzlr added the enhancement New feature or request label Nov 6, 2024
@adtzlr adtzlr self-assigned this Nov 6, 2024
@codecov

codecov Bot commented Nov 6, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.67%. Comparing base (da62927) to head (2b37caf).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #888   +/-   ##
=======================================
  Coverage   97.67%   97.67%           
=======================================
  Files         166      166           
  Lines        6063     6068    +5     
=======================================
+ Hits         5922     5927    +5     
  Misses        141      141           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adtzlr adtzlr merged commit 706a638 into main Nov 6, 2024
@adtzlr adtzlr deleted the enhance-region-astype branch November 6, 2024 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Region.astype(dtype) should have a copy=True flag

1 participant