Return bytes in EpubHtml's get_body_content #319
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
269927e to
99ea478
Compare
The documentation of methods get_body_content and get_content states that in python 3 they return bytes, but were previously returning strings (in some situations).
99ea478 to
4391071
Compare
Contributor
Author
|
If #293 were to be merged, this commit would need changes (i.e. replacing |
replacing six.b() is only needed to support Python2.5 |
Owner
|
Thanks for this! Removing dependancy on six will go according to issue #318 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The method's documentation states that in python 3 it return bytes, but was previously returning strings in some situations.