Tags: afalko/zipkin
Tags
Ignores empty rabbit URI property
The default is empty and we accidentally interpreted that as a real URI.
Ex: `uri: ${RABBIT_URI:}`
Caused:
```
| Caused by: java.lang.NullPointerException: null
query_1 | at com.rabbitmq.client.ConnectionFactory.setUri(ConnectionFactory.java:277) ~[amqp-client-4.5.0.jar!/:4.5.0]
query_1 | at zipkin.autoconfigure.collector.rabbitmq.ZipkinRabbitMQCollectorProperties.toBuilder(ZipkinRabbitMQCollectorProperties.java:132) ~[zipkin-autoconfigure-collector-rabbitmq-2.7.0.jar!/:na]
query_1 | at zipkin.autoconfigure.collector.rabbitmq.ZipkinRabbitMQCollectorAutoConfiguration.rabbitMq(ZipkinRabbitMQCollectorAutoConfiguration.java:43) ~[zipkin-autoconfigure-collector-rabbitmq-2.7.0.jar!/:na]
query_1 |
```
Thanks @marcingrzejszczak for pointing this out
Removes scribe from the default jar, as an optional module This removes scribe and the 2 year abandoned library it uses from the default server jar. A follow-up change will integrate it conditionally in the docker image similar to how we integrate kafka10.
PreviousNext