proxy: revive TCP proxy mode #496
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was intentionally disabled as we did some major refactoring. Add it back now that things have stablized.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR revives the TCP proxy functionality that was previously disabled during major refactoring. The purpose is to restore TCP proxy mode now that the codebase has stabilized.
- Restores TCP proxy route conversion and backend handling
- Adds TCP connection support to the client module
- Implements proper TCP proxy logic with bidirectional copying
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| crates/agentgateway/src/types/local.rs | Restores TCP route conversion logic and backend reference handling |
| crates/agentgateway/src/types/agent_xds.rs | Adds missing alpn field to BackendTLS configuration |
| crates/agentgateway/src/test_helpers/proxymock.rs | Adds TCP proxy test helpers and mock setup functions |
| crates/agentgateway/src/proxy/tcpproxy.rs | Implements complete TCP proxy functionality with backend resolution |
| crates/agentgateway/src/proxy/mod.rs | Adds TCP-specific error types for upstream call failures |
| crates/agentgateway/src/proxy/httpproxy.rs | Refactors service call building into reusable function and makes structs public |
| crates/agentgateway/src/proxy/gateway_test.rs | Adds basic TCP proxy test case |
| crates/agentgateway/src/proxy/gateway.rs | Moves TCP metrics tracking to gateway level |
| crates/agentgateway/src/http/backendtls.rs | Adds ALPN protocol configuration support |
| crates/agentgateway/src/client/mod.rs | Adds TCP call support with bidirectional connection copying |
| crates/agentgateway/src/client/hyperrustls/mod.rs | Renames HttpsConnector to TLSConnector for broader use |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Comment on lines
+99
to
+102
| let service = match &selected_backend.backend { | ||
| SimpleBackend::Service(svc, _) => Some(strng::format!("{}/{}", svc.namespace, svc.hostname)), | ||
| _ => None, | ||
| }; |
There was a problem hiding this comment.
[nitpick] Consider extracting this service name formatting logic into a helper function since it may be reused elsewhere in the codebase.
| return Err(ProxyError::NoHealthyEndpoints); | ||
| }; | ||
| let dest = SocketAddr::from((*ip, target_port)); | ||
| log.add(move |l| l.request_handle = Some(handle)); |
There was a problem hiding this comment.
The log parameter is &mut Option<&mut RequestLog> but this code assumes it's always Some. This will panic if log is None.
Suggested change
| log.add(move |l| l.request_handle = Some(handle)); | |
| if let Some(log) = log { | |
| log.add(move |l| l.request_handle = Some(handle)); | |
| } |
| use http_body_util::BodyExt; | ||
| use hyper_util_fork::rt::TokioIo; | ||
| use rustls_pki_types::{DnsName, ServerName}; | ||
| use tonic::codegen::Service; |
There was a problem hiding this comment.
This import appears to be unused in the context of the changes shown. Consider removing if not needed.
Suggested change
| use tonic::codegen::Service; |
artberger
added a commit
to agentgateway/website
that referenced
this pull request
Oct 15, 2025
Followup to agentgateway/agentgateway#496 Signed-off-by: Art Berger <art.berger@solo.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was intentionally disabled as we did some major refactoring. Add it back now that things have stablized.