http: increase idle timeout from 2s to 10min #508
Conversation
There was a problem hiding this comment.
Pull Request Overview
Increases the HTTP/1.1 idle timeout from the default 30 seconds to 10 minutes to prevent premature connection timeouts for long-running requests.
- Added a configurable
http1IdleTimeoutparameter with a default value of 10 minutes - Modified connection handling to suppress timeout error logging for idle connection closures
- Updated the hyper server configuration to use the new timeout value
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| schema/local.json | Adds schema definition and default value for the new http1IdleTimeout parameter |
| schema/README.md | Documents the new http1IdleTimeout configuration option |
| crates/agentgateway/src/proxy/gateway.rs | Updates server configuration and error handling for idle timeouts |
| crates/agentgateway/src/lib.rs | Defines the new configuration field with Duration type and default value |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| return Ok(()); | ||
| } | ||
| } | ||
| anyhow::bail!("e"); |
There was a problem hiding this comment.
The error message is hardcoded as 'e' instead of using the actual error. This should be anyhow::bail!(\"{e:?}\"); to preserve the original error information.
| anyhow::bail!("e"); | |
| anyhow::bail!("{e:?}"); |
| b.http1().max_headers(*m); | ||
| } | ||
| b.http1().header_read_timeout(Some(Duration::from_secs(2))); | ||
| b.http1().header_read_timeout(Some(*http1_idle_timeout)); |
There was a problem hiding this comment.
The header_read_timeout method is being used with the idle timeout value, but this appears to be semantically incorrect. Header read timeout should remain a short duration (like the original 2 seconds) for security reasons, while idle timeout should be configured separately using http1().keep_alive() or similar methods.
| b.http1().header_read_timeout(Some(*http1_idle_timeout)); | |
| b.http1().header_read_timeout(Some(std::time::Duration::from_secs(2))); | |
| b.http1().keep_alive(Some(*http1_idle_timeout)); |
0c97b7d to
4934321
Compare
see #504