cel: add replaceRegex function #518
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new regexReplace function to the CEL implementation and refactors existing function names to use camelCase instead of snake_case to align with CEL standards.
- Added new
regexReplacefunction for regex-based string replacement - Renamed functions from snake_case to camelCase (e.g.,
base64_encodetobase64Encode,map_valuestomapValues) - Updated documentation and tests to reflect the new function names
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| crates/agentgateway/src/cel/functions.rs | Adds the new regexReplace function implementation and renames existing functions to camelCase |
| crates/agentgateway/src/cel/functions_tests.rs | Updates test cases to use the new camelCase function names and adds tests for regexReplace |
| architecture/cel.md | Updates documentation to reflect the new function names and adds documentation for regexReplace |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Breaking change: functions have been changed to camel case to align with CEL standards
60ffbfb to
0718aea
Compare
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change: functions have been changed to camel case to align with CEL standards