cel: add scheme and host to request context #528
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds scheme and host information to the CEL (Common Expression Language) request context, enhancing the available HTTP request attributes for expression evaluation.
- Adds
hostandschemefields to the request context structure - Updates documentation and schema definitions to include examples and descriptions
- Integrates http-serde dependency for proper serialization of HTTP types
Reviewed Changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| schema/cel.json | Adds host and scheme fields to JSON schema with nullable string types |
| schema/README.md | Updates documentation table with new fields but missing descriptions |
| crates/agentgateway/src/cel/mod.rs | Implements host and scheme extraction from URI in request context |
| Cargo.toml | Adds http-serde dependency for HTTP type serialization |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Comment on lines
+866
to
+867
| |`request.host`|| | ||
| |`request.scheme`|| |
There was a problem hiding this comment.
The descriptions for request.host and request.scheme fields are missing. Consider adding descriptions like 'The host component of the request URI' and 'The scheme component of the request URI (e.g., http, https)' respectively.
Suggested change
| |`request.host`|| | |
| |`request.scheme`|| | |
| |`request.host`|The host component of the request URI.| | |
| |`request.scheme`|The scheme component of the request URI (e.g., http, https).| |
74ccaea to
21460c5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.