Implement new Xds API #588
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: npolshakova <nina.polshakova@solo.io>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the policy system to consolidate policy types and introduce frontend policies. The main objectives are:
- Merge
gatewayPoliciesinto a unifiedpoliciessystem with phase control - Remove deprecated
listenerconfig in favor of newfrontendPolicies - Restructure policies into three categories: Frontend, Traffic, and Backend
- Improve policy application and type safety
Key Changes
- Unified policy system with
PolicyTypeenum containing Frontend, Traffic (with phase), and Backend policies - Introduced
frontendPoliciesfor gateway-level HTTP, TLS, TCP, and access log configurations - Removed
gatewayPoliciesarray andlistenerconfig from root - Changed default pool idle timeout from
10sto1m30s
Reviewed Changes
Copilot reviewed 31 out of 33 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| schema/local.json | Added frontendPolicies schema, changed pool idle timeout default, removed listener config schema |
| schema/local.md | Documentation cleanup (file deletion) |
| schema/README.md | Updated schema documentation to reflect policy restructuring |
| crates/agentgateway/src/types/local.rs | Refactored policy conversion logic to use unified PolicyType |
| crates/agentgateway/src/types/frontend.rs | New file defining frontend policy types (HTTP, TLS, TCP, LoggingPolicy) |
| crates/agentgateway/src/types/agent.rs | Restructured policy types into PolicyType enum with three variants |
| crates/agentgateway/src/types/agent_xds.rs | Updated XDS deserialization for new policy structure |
| crates/agentgateway/src/store/binds.rs | Updated store to handle unified policies and frontend policies |
| crates/agentgateway/src/proxy/httpproxy.rs | Refactored to use frontend policies and new policy application |
| crates/agentgateway/src/proxy/gateway.rs | Updated gateway to apply frontend policies |
| crates/agentgateway/src/transport/stream.rs | Added TCP settings application (incomplete implementation) |
| crates/agentgateway/src/lib.rs | Removed ListenerConfig, moved to frontend types |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| socket2::SockRef::from(tcp).set_tcp_keepalive(&ka) | ||
| ); | ||
| } | ||
| todo!() |
There was a problem hiding this comment.
The apply_tcp_settings function contains a todo!() macro which will panic at runtime. This appears to be incomplete code that should either be removed or implemented before merging.
Suggested change
| todo!() | |
| // All requested TCP settings have been applied. |
This was referenced Nov 3, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.