fix(sensor): deliver subscription signals to via refs#200
Merged
Conversation
4835fb6 to
864f739
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
eventually_state/3assertion against agent-visible stateviarefs before sensor delivery so plugin subscription sensors can actually reachAgentServerviatuple deliveryWhy
Strengthening the test from #198 exposed that subscription sensors were started with a registry
viaref, butJido.Sensor.Runtimeonly delivered directly to pids and otherwise fell through to generic async dispatch. The previous test masked that because it never asserted agent-side delivery.Verification
MIX_ENV=test mix test test/jido/sensor/runtime_test.exsMIX_ENV=test mix test test/jido/agent_server/plugin_subscriptions_test.exs