Better SOAP error handling#141
Merged
Merged
Conversation
Collaborator
|
Hi You can see me using it here... So I'll do the commit because try/catch is fine. But _get may give cleaner looking code in the future. Thanks |
Contributor
Author
|
I did not know about that library, thank you for the information. |
Collaborator
|
There are a few NodeJS libraries that are very popular and used in lots of software. They are libraries packed will handy functions to make writing javascript easier. Roger |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On SOAP error, some cameras send a wrong SOAP structure (see Issue #73).
This PR permit to avoid having the error
"TypeError: Cannot read property '0' of undefined", but instead will try to read bothreasonanddetailinformation, if one of them is wrong, we can still get the other.