Skip to content

Modify null pointer in Cam.js#166

Merged
agsh merged 1 commit into
agsh:masterfrom
haoguangsu:master
Jun 10, 2020
Merged

Modify null pointer in Cam.js#166
agsh merged 1 commit into
agsh:masterfrom
haoguangsu:master

Conversation

@haoguangsu

Copy link
Copy Markdown
Contributor

image
In some cases, a null pointer may be appear here.

@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.09%) to 87.939% when pulling d807b48 on hwx350758:master into e2ab59e on agsh:master.

Comment thread lib/cam.js
, fps: this.defaultProfiles[idx].videoEncoderConfiguration.rateControl.frameLimit
, bitrate: this.defaultProfiles[idx].videoEncoderConfiguration.rateControl.bitrateLimit
, profileToken: this.defaultProfiles[idx].$.token
};

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
In some cases, a null pointer may appear here

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@agsh agsh merged commit eae4680 into agsh:master Jun 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants