Skip to content

Conversation

@Fusion
Copy link

@Fusion Fusion commented May 15, 2021

A new pull request to celebrate the progress of tunnelto's code base!

Anyway, this is my sqlite support pull request again, but as you requested it is now a conditional feature and implements the proper traits in its own separate file.

As usual, thanks for being patient with this very amateur Rust dev.

@Fusion
Copy link
Author

Fusion commented May 29, 2021

I hope I didn't make any mistake. I've never used github's UI to resolve conflicts before :/

Anyway, let me know.

PS: I am not putting the "db_connection_string" string behind a feature gate because:

  • as named, it could be used with any additional database supported in future releases
  • conditionals here would render the source code much uglier, as you previously pointed out

@jakswa
Copy link

jakswa commented Jul 14, 2021

❤️ Just wanted to pop in and say thanks for this PR. Today I had trouble with the hosted tunnelto.dev service (502s for an extended period) and this branch got me a self-hosted version pretty quickly!

@jakswa
Copy link

jakswa commented Sep 29, 2022

Was there hesitation here on the vendor-agnostic storage option of sqlite? I was recently thinking that I've enjoyed being a paying subscriber long enough that I'd fork this sqlite branch and spin up an internally-hosted instance at my company, for employees to rely on (data privacy concerns with the public service). But in case the lack of movement here is a sign of other context I'm missing, I thought it was worth a quick comment.

@Fusion
Copy link
Author

Fusion commented Sep 30, 2022

@agrinman any update? Let me know if I should bring this now fairly dated pull request up to date.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants