Skip to content

Conversation

@ocean
Copy link
Member

@ocean ocean commented Mar 3, 2021

I've also updated the Makefile to run and fixed the targets to build cross-compiled binaries and tar them up for release.

Also updated to use Go modules.

Remove unneeded GO15VENDOREXPERIMENT, turn LDFLAGS into variable.
@frankcarey
Copy link
Contributor

Nice, will take a look this weekend

@hanoii
Copy link
Contributor

hanoii commented Apr 13, 2022

🙏 🥺

@frankcarey frankcarey merged commit eea7bb1 into ahoy-cli:master May 16, 2022
@frankcarey
Copy link
Contributor

by "this weekend" I meant a weekend a year from then apparently. Sorry about this. I'm going to make a ticket about my limited availability in the last few years, but I've added a couple maintainers that ARE involved to help keep things moving forward. Thanks for your patience

@hanoii
Copy link
Contributor

hanoii commented May 17, 2022

@frankcarey are you planning on releasing a new version with the ARM binary?

@frankcarey
Copy link
Contributor

Yes, we should get feedback that ARM and other platforms are indeed working for folks and then release a new set of binaries. For the homebrew users we'll need to update as well.

@hanoii
Copy link
Contributor

hanoii commented May 17, 2022 via email

@ocean
Copy link
Member Author

ocean commented May 18, 2022

@hanoii Someone in the Homebrew project already updated the ahoy recipe to build for M1 / ARM. I haven't tested it yet as I'm still using my own built version, but will test it soon.

@frankcarey Have you attempting building on Windows yet? If not we can try setting up a Windows build with a GitHub Action I think and test it out.

@frankcarey
Copy link
Contributor

Yeah, we used to have circle ci setup, but it seems to be broken for some reason. Would love to get tests and builds happening again.

@frankcarey
Copy link
Contributor

On windows, I had it working IIRC, as you can now pick your interpreter (besides bash) or have it working in gitbash.. but last time I tried the binary, there was some issue I think.

@hanoii
Copy link
Contributor

hanoii commented May 18, 2022

@ocean right, I was confused. I was using homebrew arm64 binary all along. But.I do use your build on the arm64 docker images

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants