-
-
Notifications
You must be signed in to change notification settings - Fork 37
Add cross-compiled binaries for Apple Silicon (darwin/arm64) and Linux ARM (linux/arm64)
#82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Remove unneeded GO15VENDOREXPERIMENT, turn LDFLAGS into variable.
|
Nice, will take a look this weekend |
|
🙏 🥺 |
|
by "this weekend" I meant a weekend a year from then apparently. Sorry about this. I'm going to make a ticket about my limited availability in the last few years, but I've added a couple maintainers that ARE involved to help keep things moving forward. Thanks for your patience |
|
@frankcarey are you planning on releasing a new version with the ARM binary? |
|
Yes, we should get feedback that ARM and other platforms are indeed working for folks and then release a new set of binaries. For the homebrew users we'll need to update as well. |
|
I’ve been using ocean’s binary on both Linux arm docker images as well as
natively on latest OS X without a single issue
|
|
@hanoii Someone in the Homebrew project already updated the @frankcarey Have you attempting building on Windows yet? If not we can try setting up a Windows build with a GitHub Action I think and test it out. |
|
Yeah, we used to have circle ci setup, but it seems to be broken for some reason. Would love to get tests and builds happening again. |
|
On windows, I had it working IIRC, as you can now pick your interpreter (besides bash) or have it working in gitbash.. but last time I tried the binary, there was some issue I think. |
|
@ocean right, I was confused. I was using homebrew arm64 binary all along. But.I do use your build on the arm64 docker images |
I've also updated the Makefile to run and fixed the targets to build cross-compiled binaries and tar them up for release.
Also updated to use Go modules.