Skip to content

bugfix: Handle array-style type field: type: ['string', 'null'] -> ty…#61

Merged
krakenalt merged 2 commits into
mainfrom
bugfix/test_different_agents
Feb 6, 2026
Merged

bugfix: Handle array-style type field: type: ['string', 'null'] -> ty…#61
krakenalt merged 2 commits into
mainfrom
bugfix/test_different_agents

Conversation

@krakenalt
Copy link
Copy Markdown
Collaborator

…pe: 'string'

Description

Motivation

Closes #

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Code refactoring (no functional changes)
  • Performance improvement
  • Test coverage improvement
  • CI/CD or tooling change

Changes Made

Testing

Test Coverage

  • Unit tests added/updated
  • Integration tests added/updated (if applicable)
  • All existing tests pass locally

Manual Testing

Method Used

  • OpenAI Python SDK
  • curl
  • Docker
  • Other:
Test commands / code

Example with OpenAI SDK:

from openai import OpenAI

client = OpenAI(base_url="http://localhost:8090", api_key="your-key")

completion = client.chat.completions.create(
    model="gpt-4",
    messages=[
        {"role": "user", "content": "Test message"}
    ],
)
print(completion.choices[0].message.content)

Example with curl:

curl -X POST http://localhost:8090/v1/chat/completions \
  -H "Content-Type: application/json" \
  -H "Authorization: Bearer your-key" \
  -d '{
    "model": "gpt-4",
    "messages": [{"role": "user", "content": "Test"}]
  }'

Checklist

Code Quality

  • Code follows the project's style guidelines
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new linter warnings (make lint)
  • Type checking passes (make mypy)
  • All tests pass (make test)

Documentation

  • I have updated the documentation accordingly
  • Docstrings follow Google style with imperative mood
  • I have added examples for new features (if applicable)
  • README.md updated (if applicable)

Dependencies

  • No new dependencies added
  • If dependencies added, they are justified and minimal
  • uv.lock updated (if dependencies changed)

Compatibility

  • Changes are compatible with Python 3.10-3.14
  • No use of type[...] syntax (use Type[...] for Python 3.8)
  • Async/sync variants both work correctly (if applicable)

Commits

  • Commit messages are clear and follow conventional commits style
  • Commits are logically organized
  • No debug code or commented-out code left in

Additional Context

Pre-merge Actions

  • Changelog updated (if applicable)
  • Version bump considered (if applicable)

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 6, 2026

🧪 Test Coverage Report

Coverage: 88.25021132713441%

Coverage Badge

@krakenalt krakenalt marked this pull request as ready for review February 6, 2026 12:54
@krakenalt krakenalt merged commit c206182 into main Feb 6, 2026
6 checks passed
@krakenalt krakenalt deleted the bugfix/test_different_agents branch February 16, 2026 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant