Remove FRE-NCtools submodule, use GFDL version instead #1138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbren12
approved these changes
Apr 7, 2021
Co-authored-by: Noah D Brenowitz <nbren12@gmail.com>
oliverwm1
pushed a commit
that referenced
this pull request
Apr 7, 2021
* Remove FRE-NCtools submodule * Use GFDL version of FRE-NCtools in post process Dockerfile
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is extra work to maintain our own fork of the FRE-NCtools repo. This PR makes the
post_process_runDocker image build the FRE-NCtools by cloning the GFDL version of the repo instead of using our version of the repo as a submodule. The submodule is also deleted.Note the
fregridtool is tested by thefv3posttests during the Docker build, so I'm confident the install worked as expected.Resolves #1137