Skip to content

Fix/issue 100 #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yakutovicha merged 4 commits into from
Jul 27, 2022
Merged

Fix/issue 100 #101

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1318cea
Suppress compatibilty warnings during app installation.
csadorf Jul 26, 2022
34db55b
Clear the log view after successful app installation / update.
csadorf Jul 26, 2022
3cf74d1
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Jul 26, 2022
b5f521a
Do not report app to be detached while app manager widget is busy.
csadorf Jul 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions home/app_manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,7 +260,11 @@ def _refresh_widget_state(self, _=None):
# Check app compatibility and show banner if not compatible.
self.compatibility_warning.layout.visibility = (
"visible"
if (self.app.is_installed() and self.app.compatible is False)
if (
not busy
and self.app.is_installed()
and self.app.compatible is False
)
else "hidden"
)

Expand Down Expand Up @@ -374,6 +378,8 @@ def _refresh_widget_state(self, _=None):
self.issue_indicator.value = f'<i class="fa fa-{warn_or_ban_icon}"></i> Unable to reach the registry server.'
elif not registered:
self.issue_indicator.value = f'<i class="fa fa-{warn_or_ban_icon}"></i> The app is not registered.'
elif busy:
self.issue_indicator.value = ""
elif detached:
self.issue_indicator.value = (
f'<i class="fa fa-{warn_or_ban_icon}"></i> The app has local modifications or was checked out '
Expand All @@ -388,7 +394,8 @@ def _refresh_widget_state(self, _=None):
)

if (
any(self.app.compatibility_info.values())
not busy
and any(self.app.compatibility_info.values())
and self.app.compatible is False
):
self.compatibility_info.value = self.COMPATIBILITY_INFO.render(
Expand Down Expand Up @@ -429,6 +436,7 @@ def _install_version(self, _=None):
self._show_msg_success(
f"Installed app ({self._formatted_version(version)})."
)
self.dependencies_log.value = ""

def _update_app(self, _):
"""Attempt to update the app."""
Expand All @@ -439,6 +447,7 @@ def _update_app(self, _):
self._show_msg_failure(str(error))
else:
self._show_msg_success("Updated app.")
self.dependencies_log.value = ""

def _uninstall_app(self, _):
"""Attempt to uninstall the app."""
Expand Down