Fix version mismatch#121
Merged
Merged
Conversation
Contributor
Author
|
@unkcpz would you mind giving me access to this repo as well? 😊 |
Member
Sure, done! You gradually have your hands on all repos 😄 |
unkcpz
approved these changes
Nov 24, 2022
unkcpz
left a comment
Member
There was a problem hiding this comment.
Looks good to me. But why it is not updated? The variable is in the bumpver setup of setup.cfg.
Contributor
Author
|
The last release was done by hand, the bumpver was introduced only in the last commit if you look at the git history. |
Member
|
I see, thanks for check! |
Contributor
Author
|
Btw: I caught this by writing a new test as part of aiidalab/aiidalab-docker-stack#327 :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the last release, the version was not actually updated.
This didn't broke anything, because this package is not published anywhere, and is installed in aiidalab-docker-stack directly from the git repo based on the git version tag, which was correct. But if you try to identify the version in the current image
it will print the old version.