Home page: Open external URL in a new tab#136
Conversation
718f6cc to
206b4a3
Compare
unkcpz
left a comment
There was a problem hiding this comment.
Looks good to me, and I think open in a new page makes sense for this case.
|
I don't know if the initial design is to try to keep all apps working in only one open tab as possible to make it more like app? I'll wait @yakutovicha to double-check. But at list for this case, we are move from home to app manager or external url, which should be regarded as the "another" app. |
|
Yeah. For me the main issue is that the loading is so slow so navigating in between pages in a single tab is very annoying. (I was thinking about whether we could make the home page into a static HTML so that it loads quickly but that's a discussion for another time). |
yakutovicha
left a comment
There was a problem hiding this comment.
I think this change is perfectly valid.
Because the home page loads so slowly, it's extra annoying if you navigate away by accident. I make ore sense to open Apps' URL in a new tab. Same for "Manage App" button.
https://github.com/aiidalab/aiidalab-home/pull/new/open-url-new-tab
Closes #124