Skip to content

Bump ruff to 0.8.3#186

Merged
danielhollas merged 1 commit into
mainfrom
bump-precommit-hooks
Dec 16, 2024
Merged

Bump ruff to 0.8.3#186
danielhollas merged 1 commit into
mainfrom
bump-precommit-hooks

Conversation

@danielhollas

Copy link
Copy Markdown
Contributor

No description provided.

import requests
import selenium.webdriver.support.expected_conditions as ec
from requests.exceptions import ConnectionError
from requests.exceptions import ConnectionError # noqa: A004

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ruff was complaining that ConnectionError shadows a builtin exception.

@danielhollas danielhollas marked this pull request as draft November 28, 2024 18:46
@danielhollas

Copy link
Copy Markdown
Contributor Author

I have no clue what is happening with pre-commit.ci, its autofix is reverting my changes needed by ruff 0.8. Marking as draft, will try again when 0.8.1 is available.

@danielhollas danielhollas marked this pull request as ready for review December 16, 2024 17:15
@danielhollas danielhollas changed the title Bump ruff to 0.8 Bump ruff to 0.8.3 Dec 16, 2024
@danielhollas danielhollas merged commit 32aff87 into main Dec 16, 2024
@danielhollas danielhollas deleted the bump-precommit-hooks branch December 16, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant