Get rid of pandas dependency#222
Conversation
|
Same comment as in the corresponding AWB PR, can we try using tabulate package so we don't have to write HTML and CSS by hand here? |
edan-bainglass
left a comment
There was a problem hiding this comment.
LGTM! @danielhollas tabulate seems limited to text-based, very simple tables. I think here, this is fine, for now. Let's not hold it back.
We should, however, settle on a robust table package and use throughout our ecosystem. Another option is to write our own, as @superstar54 did with the TableWidget in the QE app. But whatever we do, we should standardize, generalize, and deploy under AWB for use by all!
danielhollas
left a comment
There was a problem hiding this comment.
@danielhollas tabulate seems limited to text-based, very simple tables.
Can you clarify what you mean by "text based"? Seems like our tables here are pretty simple and we don't need anything fancy?
Okay, I don't want to block, but would be good to write things down in an issue.
@yakutovicha can you merge main and re-run pre-commit. I think this should just re-format the code and fix the failing pre-commit. Alternatively, just merge this and I'll deal with the failing pre-commit in a follow-up PR (sorry about that, I shouldn't have merged that PR).
Just simply, text-based HTML tables. But yeah, if that's what is used here, one would imagine @yakutovicha same comment as here |
Here we go: before: after: The only noticeable change is the process status. Before, |
|
So, can I merge, @edan-bainglass? |
done #224 |
fixes #221