Skip to content

Adding relax max_step widget#1063

Merged
AndresOrtegaGuerrero merged 3 commits into
aiidalab:mainfrom
AndresOrtegaGuerrero:new_geoopt_steps_widget
Jan 8, 2025
Merged

Adding relax max_step widget#1063
AndresOrtegaGuerrero merged 3 commits into
aiidalab:mainfrom
AndresOrtegaGuerrero:new_geoopt_steps_widget

Conversation

@AndresOrtegaGuerrero
Copy link
Copy Markdown
Member

This pull request addresses issue #748 by introducing a widget that allows users to set the maximum number of steps for structural relaxation calculations in Quantum ESPRESSO. The default is 50 steps, but some systems may require more to achieve convergence. This feature prevents premature termination of calculations due to insufficient iteration limits. Additionally, systems requiring tighter convergence criteria, such as those involved in phonon calculations, may benefit from increased step limits.

image

@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 8, 2025

Codecov Report

Attention: Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.

Project coverage is 67.88%. Comparing base (084431f) to head (441feb3).
Report is 149 commits behind head on main.

Files with missing lines Patch % Lines
...aiidalab_qe/app/configuration/advanced/advanced.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1063      +/-   ##
==========================================
+ Coverage   67.86%   67.88%   +0.01%     
==========================================
  Files         112      112              
  Lines        6668     6675       +7     
==========================================
+ Hits         4525     4531       +6     
- Misses       2143     2144       +1     
Flag Coverage Δ
python-3.11 67.88% <71.42%> (+0.01%) ⬆️
python-3.9 67.90% <71.42%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@edan-bainglass
Copy link
Copy Markdown
Member

@AndresOrtegaGuerrero this ready?

@AndresOrtegaGuerrero
Copy link
Copy Markdown
Member Author

yes

Copy link
Copy Markdown
Member

@edan-bainglass edan-bainglass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@AndresOrtegaGuerrero AndresOrtegaGuerrero merged commit 875001a into aiidalab:main Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants