Skip to content

using ui_parameters to set the report#910

Merged
AndresOrtegaGuerrero merged 2 commits into
mainfrom
fix_909_import_incompatibility
Oct 31, 2024
Merged

using ui_parameters to set the report#910
AndresOrtegaGuerrero merged 2 commits into
mainfrom
fix_909_import_incompatibility

Conversation

@AndresOrtegaGuerrero
Copy link
Copy Markdown
Member

@AndresOrtegaGuerrero AndresOrtegaGuerrero commented Oct 31, 2024

This solves #909 and makes the app compatible to upload imported nodes from another account using QeApp

@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.06%. Comparing base (ef677e7) to head (c5c96c5).
Report is 114 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #910   +/-   ##
=======================================
  Coverage   67.06%   67.06%           
=======================================
  Files          51       51           
  Lines        4713     4713           
=======================================
  Hits         3161     3161           
  Misses       1552     1552           
Flag Coverage Δ
python-3.11 67.06% <100.00%> (ø)
python-3.9 67.09% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Copy Markdown
Member

@superstar54 superstar54 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@AndresOrtegaGuerrero AndresOrtegaGuerrero merged commit 2787397 into main Oct 31, 2024
@AndresOrtegaGuerrero AndresOrtegaGuerrero deleted the fix_909_import_incompatibility branch October 31, 2024 11:37
edan-bainglass pushed a commit to edan-bainglass/aiidalab-qe that referenced this pull request Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants