Store already added node viewer and load it when needed#921
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #921 +/- ##
==========================================
- Coverage 67.06% 66.92% -0.14%
==========================================
Files 51 51
Lines 4715 4726 +11
==========================================
+ Hits 3162 3163 +1
- Misses 1553 1563 +10
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Member
|
@superstar54 thank you for reopening this! It will greatly improve the usefulness of the lazy-loading work implemented in #802 w.r.t the results section. Will review ASAP! |
edan-bainglass
approved these changes
Nov 9, 2024
Member
edan-bainglass
left a comment
There was a problem hiding this comment.
LGTM! As stated, this will come in handy when node_views become MVCs. Good to not have to recreate them 🙂
edan-bainglass
added a commit
to edan-bainglass/aiidalab-qe
that referenced
this pull request
Nov 11, 2024
edan-bainglass
added a commit
to edan-bainglass/aiidalab-qe
that referenced
this pull request
Nov 11, 2024
edan-bainglass
added a commit
that referenced
this pull request
Nov 11, 2024
edan-bainglass
added a commit
to edan-bainglass/aiidalab-qe
that referenced
this pull request
Nov 11, 2024
edan-bainglass
added a commit
to aiidalab/aiidalab-widgets-base
that referenced
this pull request
Feb 15, 2025
Moving node view caching mechanism implemented by @superstar54 in the QE app (aiidalab/aiidalab-qe#921) into `AiidaNodeViewWidget`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reopen PR #560 .
In aiidalab-widgets-base/viewer.py, it creates a new
viewerevery time we select a new AiiDA node, and the viewer is not saved in the app, so we can not reuse it later. This has two drawbacks:reset.This PR stores the already added viewer and reuses it later.
This is also needed in the
lazy-loadingPR.