Skip to content

modifications to the EditStructureData Widgets#956

Merged
AndresOrtegaGuerrero merged 3 commits into
aiidalab:mainfrom
AndresOrtegaGuerrero:atoms_tag_widget_refactoring
Nov 28, 2024
Merged

modifications to the EditStructureData Widgets#956
AndresOrtegaGuerrero merged 3 commits into
aiidalab:mainfrom
AndresOrtegaGuerrero:atoms_tag_widget_refactoring

Conversation

@AndresOrtegaGuerrero
Copy link
Copy Markdown
Member

@AndresOrtegaGuerrero AndresOrtegaGuerrero commented Nov 28, 2024

image

@codecov
Copy link
Copy Markdown

codecov Bot commented Nov 28, 2024

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 67.84%. Comparing base (92b8299) to head (06b3e84).
Report is 139 commits behind head on main.

Files with missing lines Patch % Lines
src/aiidalab_qe/common/widgets.py 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #956      +/-   ##
==========================================
- Coverage   67.85%   67.84%   -0.02%     
==========================================
  Files         110      110              
  Lines        6206     6213       +7     
==========================================
+ Hits         4211     4215       +4     
- Misses       1995     1998       +3     
Flag Coverage Δ
python-3.11 67.84% <0.00%> (-0.02%) ⬇️
python-3.9 67.84% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Copy Markdown
Member

@cpignedoli cpignedoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would approve this state and leave to additional PRs refinements. Reorganizing the content of the three tabs will require a more in depth action.

@AndresOrtegaGuerrero AndresOrtegaGuerrero merged commit 9cebb52 into aiidalab:main Nov 28, 2024
AndresOrtegaGuerrero added a commit that referenced this pull request Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants