Wait for event handlers completion on datachannel open #1394
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When opening a datachannel, the event handler is supposed to use the channel reference to add handlers for channel events. However, if the datachannel open event handler is an async function, its execution is delayed and events could be lost if they happen in the meantime.
209e30c to
06fe5de
Compare
Collaborator
|
Could we please have a unit test that captures the condition you are trying to fix? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When opening a datachannel, the event handler is supposed to use the channel reference to add handlers for channel events. However, if the datachannel open event handler is an async function, its execution is delayed and events could be lost if they happen in the meantime.
We encountered this issue since the application on the other side tried to open multiple channels and immediately started sending messages. While the issue didn't always happen, if a message was sent before having the coroutine handler for the
datachannelevent executed that message would effectively be lost. Waiting for the event handler completion ensures that we can register the channel event handlers.