Allow getting nodes by attributes#982
Merged
maypink merged 5 commits intoNov 18, 2022
Merged
Conversation
Collaborator
Author
|
не уверена, что эта логика должна быть методами в пайплайне, а не функциями извне, но использовать так и правда удобнее |
gkirgizov
reviewed
Nov 16, 2022
gkirgizov
left a comment
Collaborator
There was a problem hiding this comment.
Эти методы нам нужны в базовом классе Graph.
Например, BAMT-у нужна эта функциональность, а они используют свой графовый класс вместо Pipeline.
Насколько я представляю, можно ввести что-то вроде проперти name в базовом классе, и на этом основываться
Collaborator
а то, что такие внешние методы уже были, я и не знал |
gkirgizov
approved these changes
Nov 18, 2022
5c2ce0e to
06a98a0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#975 issue