Skip to content

Release fixes for multi-objective optimization#996

Merged
gkirgizov merged 9 commits into
masterfrom
release_fixes
Dec 12, 2022
Merged

Release fixes for multi-objective optimization#996
gkirgizov merged 9 commits into
masterfrom
release_fixes

Conversation

@gkirgizov

@gkirgizov gkirgizov commented Dec 1, 2022

Copy link
Copy Markdown
Collaborator

These fixes came from experiments with abstract graph optimization (synthtic task) that seems necessary for the release.

Apparently, Multi-Objective optimization was broken.

Also closes #997

@gkirgizov gkirgizov added the bug Something isn't working label Dec 1, 2022
@nicl-nno

nicl-nno commented Dec 1, 2022

Copy link
Copy Markdown
Collaborator

Apparently, Multi-Objective optimization was broken.

Может это каким-то высокоуровневым тестом заодно проверить? Например, для пары целевых функций, где одна - число узлов в графе со знаком плюс, а другая - со знаком минус. Тогда оптимизатор должен найти полный набор.

Comment thread fedot/core/optimisers/archive/generation_keeper.py Outdated
Comment thread fedot/core/optimisers/archive/generation_keeper.py Outdated
@YamLyubov YamLyubov self-requested a review December 2, 2022 09:23
Comment thread fedot/core/optimisers/archive/generation_keeper.py Outdated
initial_generation: Optional first generation;
NB: if None then keeper is created in inconsistent state and requires an initial .append().
similar: a function that tells in the case of multi-objective optimization
tells the Pareto front whether or not two individuals are similar, optional.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Тут очепятка: два раза tells

@gkirgizov

Copy link
Copy Markdown
Collaborator Author

Apparently, Multi-Objective optimization was broken.

Может это каким-то высокоуровневым тестом заодно проверить? Например, для пары целевых функций, где одна - число узлов в графе со знаком плюс, а другая - со знаком минус. Тогда оптимизатор должен найти полный набор.

Добавил интеграционный тест в fcfee61

@gkirgizov gkirgizov merged commit dde69fe into master Dec 12, 2022
@gkirgizov gkirgizov deleted the release_fixes branch December 12, 2022 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make an integration test for multi-objective improvement

3 participants