Reproducibility fixes #1351
Merged
Reproducibility fixes #1351
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @VadimsAhmers! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2024-12-16 21:10:40 UTC |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1351 +/- ##
==========================================
- Coverage 80.33% 80.32% -0.01%
==========================================
Files 146 146
Lines 10464 10470 +6
==========================================
+ Hits 8406 8410 +4
- Misses 2058 2060 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
nicl-nno
reviewed
Dec 16, 2024
| tuner_tuned_window = tuned_pipeline.nodes[-1].parameters['window_size'] | ||
|
|
||
| assert autotuned_window != tuner_tuned_window | ||
| # check that WindowSizeSelector runs twice due to tuner graph copying in initialization |
Collaborator
There was a problem hiding this comment.
Тогда комментарий можно убрать.
nicl-nno
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Доделываю #1278
repr-fixсmaster, все коммиты объединены в один