Disallow setting remote.storage.enable when diskless.enable is set to true#513
Open
giuseppelillo wants to merge 1 commit intomainfrom
Open
Disallow setting remote.storage.enable when diskless.enable is set to true#513giuseppelillo wants to merge 1 commit intomainfrom
giuseppelillo wants to merge 1 commit intomainfrom
Conversation
ce5f64f to
4bf07e1
Compare
storage/src/main/java/org/apache/kafka/storage/internals/log/LogConfig.java
Outdated
Show resolved
Hide resolved
storage/src/main/java/org/apache/kafka/storage/internals/log/LogConfig.java
Outdated
Show resolved
Hide resolved
4bf07e1 to
a411dc4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Separates two different kind of topics:
diskless.enable=true, whileremote.storage.enablecannot be set for these types of topicsremote.storage.enable=trueThe only possible transition is from
remote.storage.enable=false(or unset) toremote.storage.enable=true. All other types of transitions are prohibited.