Skip to content

test(inkless:switch): add consolidated diskless integration tests with transition matrix#617

Merged
viktorsomogyi merged 2 commits into
mainfrom
jeqo/kc-150-invariant-test
Jun 1, 2026
Merged

test(inkless:switch): add consolidated diskless integration tests with transition matrix#617
viktorsomogyi merged 2 commits into
mainfrom
jeqo/kc-150-invariant-test

Conversation

@jeqo

@jeqo jeqo commented May 28, 2026

Copy link
Copy Markdown
Contributor

Add integration tests in DisklessAndRemoteStorageConfigsTest that exercise the full controller+broker path for topic type transitions under consolidation.
Cover all 9 transition scenarios including allow-from-classic gate.
Document the transition matrix as Javadoc on both LogConfigTest and the integration test class.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds Java parameterized invariant tests for LogConfig.validate(...) around topic type creation and alteration between CLASSIC, TIERED, and DISKLESS modes.

Changes:

  • Adds creation scenario coverage for valid/invalid diskless and remote-storage combinations.
  • Adds alter scenario coverage for CLASSIC, TIERED, and DISKLESS transition paths.
  • Adds local helpers and expected validation error constants for the test matrix.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@jeqo jeqo force-pushed the jeqo/kc-150-invariant-test branch from 8bf4f3a to 40c1c81 Compare May 28, 2026 10:01
@jeqo jeqo requested a review from Copilot May 28, 2026 10:18

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

Base automatically changed from jeqo/kc-149-diskless-remote-storage-config to main May 28, 2026 13:20
@jeqo jeqo marked this pull request as ready for review May 28, 2026 13:21
@jeqo jeqo force-pushed the jeqo/kc-150-invariant-test branch from 40c1c81 to aba7f1f Compare May 28, 2026 13:22
@jeqo jeqo marked this pull request as draft May 28, 2026 13:26
@jeqo jeqo requested a review from Copilot May 28, 2026 22:19
@jeqo jeqo force-pushed the jeqo/kc-150-invariant-test branch from aba7f1f to b3aaaac Compare May 28, 2026 22:21

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated no new comments.

@jeqo jeqo force-pushed the jeqo/kc-150-invariant-test branch from b3aaaac to 1b72db1 Compare May 28, 2026 22:25
@jeqo jeqo changed the base branch from main to jeqo/kc-151-auto-enable-rs May 28, 2026 22:26
@jeqo jeqo changed the title test(inkless:switch): add invariant tests for topic type transitions test(inkless:switch): add consolidated diskless integration tests with transition matrix May 28, 2026
Base automatically changed from jeqo/kc-151-auto-enable-rs to main May 29, 2026 06:54
@jeqo jeqo marked this pull request as ready for review May 29, 2026 06:55
@jeqo jeqo requested a review from giuseppelillo May 29, 2026 06:55
@jeqo jeqo force-pushed the jeqo/kc-150-invariant-test branch from 1b72db1 to 6c172c7 Compare May 29, 2026 08:49
@viktorsomogyi viktorsomogyi self-requested a review June 1, 2026 08:05
Comment thread core/src/test/java/kafka/server/DisklessAndRemoteStorageConfigsTest.java Outdated
Comment thread core/src/test/java/kafka/server/DisklessAndRemoteStorageConfigsTest.java Outdated
Comment thread core/src/test/java/kafka/server/DisklessAndRemoteStorageConfigsTest.java Outdated
Comment thread core/src/test/java/kafka/server/DisklessAndRemoteStorageConfigsTest.java Outdated
…h transition matrix

Add integration tests in DisklessAndRemoteStorageConfigsTest that exercise
the full controller+broker path for topic type transitions under
consolidation. Cover all 9 transition scenarios including allow-from-classic
gate. Document the transition matrix as Javadoc on both LogConfigTest and
the integration test class.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@jeqo jeqo force-pushed the jeqo/kc-150-invariant-test branch from 6c172c7 to c784afc Compare June 1, 2026 09:45
@jeqo jeqo requested a review from viktorsomogyi June 1, 2026 10:10
@viktorsomogyi viktorsomogyi merged commit 4759816 into main Jun 1, 2026
6 checks passed
@viktorsomogyi viktorsomogyi deleted the jeqo/kc-150-invariant-test branch June 1, 2026 11:54
giuseppelillo pushed a commit that referenced this pull request Jun 4, 2026
…h transition matrix (#617)

Add integration tests in DisklessAndRemoteStorageConfigsTest that exercise
the full controller+broker path for topic type transitions under
consolidation. Cover all 9 transition scenarios including allow-from-classic
gate. Document the transition matrix as Javadoc on both LogConfigTest and
the integration test class.

---------

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
gqmelo pushed a commit that referenced this pull request Jun 4, 2026
…h transition matrix (#617)

Add integration tests in DisklessAndRemoteStorageConfigsTest that exercise
the full controller+broker path for topic type transitions under
consolidation. Cover all 9 transition scenarios including allow-from-classic
gate. Document the transition matrix as Javadoc on both LogConfigTest and
the integration test class.

---------

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants