fix: win32 terminal interface via native image#287
Open
sgammon wants to merge 1 commit into
Open
Conversation
Fixes use of SVM `Word` types, via the Native Image C API on Windows. Such types cannot be intermixed with with regular JVM `Object` types. Newer versions of the compiler find and enforce this, leading to failures at build time. Fixes and closes ajalt#286 Signed-off-by: Sam Gammon <sam@elide.dev>
Owner
|
Thank you! It looks like you changed the indent to 2 spaces, which adds noise and doesn't match the rest of the project. Can you undo that? |
Author
|
@ajalt Yes, sorry, I was hoping to test with CI because I couldn't get the build working locally off the bat. What version of Java should I be using? And are you using Spotless here, or how do I format? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes use of SVM
Wordtypes, via the Native Image C API on Windows. Such types cannot be intermixed with with regular JVMObjecttypes. Newer versions of the compiler find and enforce this, leading to failures at build time.Fixes and closes #286
cc / @ajalt big fan btw, hi again, we are using Mordant in Elide! 😄