Skip to content

Add "enableDoubleFindToReplace" option #5346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
nunziotocci wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Add "enableDoubleFindToReplace" option #5346

nunziotocci wants to merge 4 commits into from

Conversation

@nunziotocci
Copy link

@nunziotocci nunziotocci commented Oct 7, 2023

Issue #, if available:
Brings back the behavior that #2653 complained about behind an option.

Description of changes:
Add "enableDoubleFindToReplace" option. This allows you to press Ctrl-F while the find window is open to toggle the replace option. I'm used to it, and so are the people at my company.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@InspiredGuy
Copy link
Contributor

InspiredGuy commented Oct 11, 2023

Thank you for the contribution. Could you please add the new option to the types declaration in ace.d.ts, add a test for the new option, and expose the option in the kitchen sink? Please refer to #5233 as an example for those

@codecov
Copy link

codecov bot commented Oct 17, 2023 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.42%. Comparing base (7a6b83e) to head (06a294f).
⚠️ Report is 423 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #5346      +/-   ##
==========================================
+ Coverage   87.41%   87.42%   +0.01%     
==========================================
  Files         574      574              
  Lines       45613    45613              
  Branches     6935     6935              
==========================================
+ Hits        39873    39878       +5     
+ Misses       5740     5735       -5
Flag Coverage Δ
unittests 87.42% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link

github-actions bot commented Dec 12, 2025

One of the public type files has been updated, plase make sure there are no backwards incompatible changes done in the PR.

@github-actions
Copy link

github-actions bot commented Dec 12, 2025

One of the public type files has been updated, plase make sure there are no backwards incompatible changes done in the PR.

@nunziotocci
Copy link
Author

nunziotocci commented Dec 12, 2025

I have added it to ace.d.ts via ace-internal.d.ts and npm run update-types. I also added it to the Kitchen Sink.

I don't see any tests for ext/searchbox. How might I go about adding one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

response-requested

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nunziotocci @InspiredGuy