=per #23739 deprecate State.using to deter Java users
#23740
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test PASSed. |
patriknw
approved these changes
Sep 27, 2017
| * Modify state transition descriptor with new state data. The data will be | ||
| * set when transitioning to the new state. | ||
| */ | ||
| @InternalApi |
Contributor
There was a problem hiding this comment.
wouldn't hurt to keep the internal marker
`State.using` is a valid pattern in regular FSM. However, for persistent FSM it makes no sense and is marked as `private[akka]`. The `private[akka]` modifier does not translate into bytecode so that Java users won't see that it should not be used. Deprecating it will allow us to remove it in the future. Fixes akka#23739.
aedea1d to
d32fa0d
Compare
|
Test PASSed. |
ktoso
approved these changes
Sep 28, 2017
lucianenache
pushed a commit
to lucianenache/akka
that referenced
this pull request
Nov 9, 2017
`State.using` is a valid pattern in regular FSM. However, for persistent FSM it makes no sense and is marked as `private[akka]`. The `private[akka]` modifier does not translate into bytecode so that Java users won't see that it should not be used. Deprecating it will allow us to remove it in the future. Fixes akka#23739.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
State.usingis a valid pattern in regular FSM. However, for persistent FSMit makes no sense and is marked as
private[akka]. Theprivate[akka]modifier doesnot translate into bytecode so that Java users won't see that it should not be used.
Deprecating it will allow us to remove it in the future.
Fixes #23739.