harden RestartSpec - remove race condition #31182
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johanandren
approved these changes
Feb 23, 2022
Contributor
johanandren
left a comment
There was a problem hiding this comment.
LGTM but I think the old naming was better.
| } | ||
| .mapMaterializedValue(_.onComplete { | ||
| case Success(_) => flowInSource.sendNext("in complete") | ||
| case Failure(_) => flowInSource.sendNext("in error") |
Contributor
There was a problem hiding this comment.
Just as a reminder of the problem: since flowInSource was a stream probe, we can't just imperatively push to it from two different threads, what was failing was that it had not yet seen demand (from the buffer(4)) in one of the sendNext cases and would throw, leading to a subsequent expectation fail in the actual test.
akka-stream-tests/src/test/scala/akka/stream/scaladsl/RestartSpec.scala
Outdated
Show resolved
Hide resolved
Contributor
Author
|
@johanandren, I will merge this one. We said that test hardening would require only one approval and I think we lost this one from sight. |
Arkatufus
added a commit
to Arkatufus/akka.net
that referenced
this pull request
Apr 1, 2025
Aaronontheweb
pushed a commit
to akkadotnet/akka.net
that referenced
this pull request
Apr 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References #30320
All credits to @johanandren that borrow me a pair of eyes and some brain cycles to find this one.