Internalize types 2 #4242
Merged
Internalize types 2 #4242
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…marked obsolete already years ago.
Internalized AlreadyCanceledCancelable because it was never possible to inherit due to the private .ctor(), and because the instance is available via Cancelable.CreateCanceled().
…ccessed by their singleton Instance property.
… to simplify code.
…heduler in unit tests that depended on it.
Member
|
@cptjazz looks like we have some merge conflicts here - probably an issue with the large HOCON update we just merged in a few moments ago. |
Contributor
Author
|
I'll try to rebase this PR on the latest changes. |
…marked obsolete already years ago.
Internalized AlreadyCanceledCancelable because it was never possible to inherit due to the private .ctor(), and because the instance is available via Cancelable.CreateCanceled().
…ccessed by their singleton Instance property.
… to simplify code.
…heduler in unit tests that depended on it.
…o internalize_types_2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes a bunch of methods/types that were marked
Obsoletefor quite some time and were unused. SomeObsoletetypes that still had internal usages were madeinternal.Furthermore I cleaned up a bit the types related to
ICancelable.Related to #4223