Skip to content

enable remember-entities with DData Cluster.Sharding #4255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Aaronontheweb merged 13 commits into from
Feb 27, 2020
Merged

enable remember-entities with DData Cluster.Sharding #4255

Aaronontheweb merged 13 commits into from
Feb 27, 2020

Conversation

@Aaronontheweb
Copy link
Member

@Aaronontheweb Aaronontheweb commented Feb 26, 2020

closes #4254

@Aaronontheweb
Copy link
Member Author

Aaronontheweb commented Feb 26, 2020

Based on the MNTR logs, I think I've figured out the issue here:

[DEBUG][2/26/2020 6:12:04 PM][Thread 0031][akka.tcp://PersistentClusterShardingRememberEntitiesSpec@localhost:53675/system/sharding/EntityCoordinator/singleton/coordinator] Shard [1] allocated at [[akka://PersistentClusterShardingRememberEntitiesSpec/system/sharding/Entity#868160794]]
[DEBUG][2/26/2020 6:12:04 PM][Thread 0033][akka.tcp://PersistentClusterShardingRememberEntitiesSpec@localhost:53675/system/sharding/Entity] Host shard [1]
[DEBUG][2/26/2020 6:12:04 PM][Thread 0033][akka.tcp://PersistentClusterShardingRememberEntitiesSpec@localhost:53675/system/sharding/Entity] Starting shard [1] in region
[DEBUG][2/26/2020 6:12:04 PM][Thread 0032][akka.tcp://PersistentClusterShardingRememberEntitiesSpec@localhost:53675/system/sharding/replicator] Received get for key shard-Entity-1-0, local value , consistency: ReadMajority(timeout=00:00:05)
[DEBUG][2/26/2020 6:12:04 PM][Thread 0032][akka.tcp://PersistentClusterShardingRememberEntitiesSpec@localhost:53675/system/sharding/replicator] Received get for key shard-Entity-1-1, local value , consistency: ReadMajority(timeout=00:00:05)
[DEBUG][2/26/2020 6:12:04 PM][Thread 0032][akka.tcp://PersistentClusterShardingRememberEntitiesSpec@localhost:53675/system/sharding/replicator] Received get for key shard-Entity-1-2, local value , consistency: ReadMajority(timeout=00:00:05)
[DEBUG][2/26/2020 6:12:04 PM][Thread 0032][akka.tcp://PersistentClusterShardingRememberEntitiesSpec@localhost:53675/system/sharding/replicator] Received get for key shard-Entity-1-3, local value , consistency: ReadMajority(timeout=00:00:05)
[DEBUG][2/26/2020 6:12:04 PM][Thread 0032][akka.tcp://PersistentClusterShardingRememberEntitiesSpec@localhost:53675/system/sharding/replicator] Received get for key shard-Entity-1-4, local value , consistency: ReadMajority(timeout=00:00:05)
[DEBUG][2/26/2020 6:12:04 PM][Thread 0012][akka.tcp://PersistentClusterShardingRememberEntitiesSpec@localhost:53675/system/sharding/Entity/1] DDataShard recovery completed shard [1] with [0] entities
[DEBUG][2/26/2020 6:12:04 PM][Thread 0034][akka.tcp://PersistentClusterShardingRememberEntitiesSpec@localhost:53675/system/sharding/Entity] Shard was initialized [1]

We execute gets for all of the missing local keys, but since there's no entity registered with that name, it never gets factored into our recovery for remember entities. I think this is a bug - don't believe we're supposed to have a key for every entity, just the key set itself (which we have.)

@Aaronontheweb
Copy link
Member Author

Aaronontheweb commented Feb 26, 2020

I take that back - the above calculations are part of the routine GetState process for DData shards

@Aaronontheweb
Copy link
Member Author

Aaronontheweb commented Feb 26, 2020

On node 2, we never call UpdateState for the entities we're supposed to remember.

@Aaronontheweb Aaronontheweb mentioned this pull request Feb 27, 2020
Closed
@Aaronontheweb Aaronontheweb marked this pull request as ready for review February 27, 2020 01:50
@Aaronontheweb Aaronontheweb merged commit c97e5b6 into akkadotnet:dev Feb 27, 2020
@Aaronontheweb Aaronontheweb deleted the 4254-enable-DData-remember-entities branch February 27, 2020 03:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

akka-cluster-sharding akka-ddata

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Akka.Cluster.Sharding: enable remember-entities for DData storage

1 participant

@Aaronontheweb