Add ActorBase lifecycle flow unit tests
#7128
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aaronontheweb
requested changes
Mar 22, 2024
Member
Aaronontheweb
left a comment
There was a problem hiding this comment.
need to make the read operation zero-allocation.
| /// <summary> | ||
| /// Retrieves all current active timer keys | ||
| /// </summary> | ||
| public ImmutableArray<object> ActiveTimers => _timers.Keys.ToImmutableArray(); |
Member
There was a problem hiding this comment.
I would just return an ICollection<object> or whatever here so we don't have to allocate an immutable array each time.
Member
There was a problem hiding this comment.
I understand that this is probably done for the purposes of making sure we don't get rugged by the collection changing out from under us, but it's better to take that risk and leave the API un-opionated
Contributor
Author
There was a problem hiding this comment.
Done, though accessing _timers.Keys actually allocates internally inside the Dictionary, but that's unavoidable.
…rkatufus/akka.net into Add_ActorBase_Lifecycle_flow_assertion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
ActiveTimerstoITimerSchedulerto retrieve all currently active timer keysActorBaselifecycle flow unit tests in relation toIWithTimerslifecycleChecklist
For significant changes, please ensure that the following have been completed (delete if not relevant):