Fix Akka.Discovery ServiceDiscovery instantiation
#7245
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arkatufus
commented
Jun 10, 2024
Comment on lines
+115
to
+121
| ctor = type.GetConstructor( | ||
| bindingAttr: bindFlags, | ||
| binder: null, | ||
| types: new[] { typeof(ExtendedActorSystem) }, | ||
| modifiers: null); | ||
| if (ctor is not null) | ||
| return (ServiceDiscovery) Activator.CreateInstance(type, _system); |
Contributor
Author
There was a problem hiding this comment.
Still accepts constructor with a single ExtendedActorSystem parameter
Comment on lines
+103
to
+113
| var ctor = type.GetConstructor( | ||
| bindingAttr: bindFlags, | ||
| binder: null, | ||
| types: new[] | ||
| { | ||
| typeof(ExtendedActorSystem), | ||
| typeof(Configuration.Config) | ||
| }, | ||
| modifiers: null); | ||
| if (ctor is not null) | ||
| return (ServiceDiscovery) Activator.CreateInstance(type, _system, config); |
Contributor
Author
There was a problem hiding this comment.
New way to instantiate ServiceDiscovery that pushes the Config into the constructor
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7242
Changes
Akka.Discovery.CreateServiceDiscovery()also accept constructor withExtendedActorSystemandConfigparameters.Try<T>and usetry..catchinsteadChecklist
For significant changes, please ensure that the following have been completed (delete if not relevant):