SelectAsync: check equality by reference on placeholder, rather than by value on struct
#7543
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n by value on `struct`
Aaronontheweb
commented
Mar 20, 2025
Member
Author
Aaronontheweb
left a comment
There was a problem hiding this comment.
Detailed my changes
Member
Author
There was a problem hiding this comment.
Removed a ton of TBD spam from here
| } | ||
|
|
||
| private static readonly Result<TOut> NotYetThere = Result.Failure<TOut>(new Exception()); | ||
| private static readonly Exception NotYetThereException = new Exception(); |
Member
Author
There was a problem hiding this comment.
Create the Exception itself as a static readonly
| private readonly Decider _decider; | ||
|
|
||
| private IBuffer<Holder<TOut>>? _buffer; | ||
| private IBuffer<Holder<TOut>> _buffer = null!; // gets initialized in PreStart |
Member
Author
There was a problem hiding this comment.
I tried but the downstream _buffer calls still complained about nullability anyway 🤷
| if (_buffer!.IsEmpty) | ||
| PullIfNeeded(); | ||
| else if (_buffer.Peek()!.Element == NotYetThere) // Shebang is fine, we checked that the buffer is not empty | ||
| else if (_buffer.Peek()!.Element.Exception == NotYetThereException) // Shebang is fine, we checked that the buffer is not empty |
Member
Author
There was a problem hiding this comment.
The fix - check the value of the Exceptions by reference. Can't get a false positive that way.
This was referenced Mar 21, 2025
This was referenced Sep 4, 2025
This was referenced Oct 7, 2025
This was referenced Oct 7, 2025
This was referenced Nov 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Supersedes #7537 using @tomachristian's research from that PR
Checklist
For significant changes, please ensure that the following have been completed (delete if not relevant):
SelectAsyncto useTry<T>#7537