Skip to content

Convert Akka.Cluster.Tools multi-node tests to async #7757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Arkatufus merged 3 commits into from
Aug 14, 2025
Merged

Convert Akka.Cluster.Tools multi-node tests to async #7757

Arkatufus merged 3 commits into from
Aug 14, 2025

Conversation

@Aaronontheweb
Copy link
Member

@Aaronontheweb Aaronontheweb commented Aug 14, 2025

Summary

  • Migrates multi-node tests in Akka.Cluster.Tools.Tests.MultiNode from blocking synchronous calls to async/await patterns
  • Fixes thread pool starvation issues that were causing 20+ second timeouts in CI environments

Changes

  • Convert test methods from void to async Task
  • Replace TestConductor.*.Wait() with await TestConductor.*Async()
  • Replace EnterBarrier() with await EnterBarrierAsync()
  • Replace Within() with await WithinAsync() where appropriate
  • Add System.Threading.Tasks imports
  • Enable TestTransport configuration where needed

Migrated Tests

  • ClusterClientDiscoverySpec
  • ClusterClientSpec
  • DistributedPubSubMediatorSpec
  • ClusterSingletonManagerDownedSpec
  • ClusterSingletonManagerSpec

Testing

  • All tests build successfully
  • Tests run and pass locally
  • No functional changes, only async/await migration

This follows the pattern established in #7750 for migrating multi-node tests to async.

Aaronontheweb and others added 2 commits August 13, 2025 21:42
@Aaronontheweb
Convert Akka.Cluster.Tools multi-node tests to async
d1ce5a5 
- Replace blocking Wait() calls with async/await patterns
- Convert test methods to async Task
- Update TestConductor operations to use async APIs
- Fix thread pool starvation issues in CI
@Arkatufus
Fix async impl
8e9b309
Arkatufus
Arkatufus approved these changes Aug 14, 2025
View reviewed changes
Copy link
Contributor

@Arkatufus Arkatufus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Arkatufus Arkatufus enabled auto-merge (squash) August 14, 2025 19:34
@Arkatufus Arkatufus merged commit 89e6405 into akkadotnet:dev Aug 14, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Arkatufus Arkatufus Arkatufus approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Aaronontheweb @Arkatufus