Hotfix async await when awaiting IO completion port based tasks #843
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Ty @nvivo for reporting this stuff |
Contributor
Author
Do not merge until @nvivo confirms that this solves the issues in his app. |
Contributor
|
The fix seems to work. Didn't see any crashes in my app anymore using ReceiveActor and the async Receive handler. |
rogeralsing
added a commit
that referenced
this pull request
Apr 13, 2015
…otfix Hotfix async await when awaiting IO completion port based tasks
This was referenced Apr 28, 2015
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another hotfix for async await.
Turns out when using the
Suspendbehavior and awaiting tasks that complete on IO completion ports, e.g.Task.Delayor IO operations, the current context was lost.This PR fixes this.