Hocon toString() with correct fallback behavior #3893
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… configuration #work in progress akkadotnet#3886
Member
|
cc @Arkatufus - how should we handle this / backport it to HOCON stand-alone? |
Member
|
@IgorFedchenko did you already implement this in the stand-alone HOCON project? |
Contributor
@Aaronontheweb Yup, this is already implemented there. |
Member
|
Implemented in akkadotnet/HOCON#181 |
Member
|
This would actually be really useful in debugging some of the issues I'm running into with #4128 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in #3886 the
Config.ToString(true)doesn't include all fallback values.The reason for the missing value is, that the toString() methods of the underlying hocon classes do skip all fallback values.
With this PR I adapted this behavior with an internal toString() that also expects an
includeFallbackboolean. The public toString() uses this internal overload with 'includeFallback = false`.Furthermore, the
toString()ofconfig, changes the internal representation. That isn't expected (at least for me). Therefore I changed this to an immutable merge and execute the merging on this temporarily new object.