[build] Fix CS0162 warnings #3941
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR fixes a number of warnings related to CS0162 (Unreachable code detected). Most of these are related to conditional debugging flags that aren't necessarrily set during a normal compilation. There are some however that are there as to clear any compile errors that would happen due to ambigious references. The pragmas are added to the function boundaries so as not to pollute the logic in the function.
Member
Aaronontheweb
left a comment
There was a problem hiding this comment.
LGTM, but left a comment on how to handle one of the warnings we disabled.
| return Deploy.Equals(other.Deploy); | ||
| } | ||
|
|
||
| #pragma warning disable CS0162 // Disabled because it's marked as a TODO |
Member
There was a problem hiding this comment.
We should probably fix this issue by closing #599 just comparing if the two supervisor strategies are equal by reference. Too complicated to do it via anything else. What do you think @sean-gilliam ?
Member
There was a problem hiding this comment.
Also, we have a serializable supervisor strategy but no one uses it because the syntax is extremely awkward.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a number of warnings related to CS0162 (Unreachable code detected).
Most of these are related to conditional debugging flags that aren't necessarrily set during a normal compilation. There are some however that are there as to clear any compile errors that would happen due to ambigious references.
The pragmas are added to the function boundaries so as not to pollute the logic in the function.